Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes-up: add missing default adwaita-icon-theme #62879

Closed
wants to merge 1 commit into from

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Jun 9, 2019

Motivation for this change

Add missing icon theme (the app looks weird on KDE).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kuznero
Copy link
Member Author

kuznero commented Jun 9, 2019

Ping @davidak, @worldofpeace. Please review and perhaps suggest another default icon theme?

@worldofpeace
Copy link
Contributor

Since this is an elementary application I'd think elementary-icon-theme would make more sense to add here.

But what's most likely the reason why this application look incorrect in KDE is that you need to install an icon theme and then configure KDE for gtk applications appropriately. See #43150 (comment) for more discussion on this topic.

@kuznero
Copy link
Member Author

kuznero commented Jun 9, 2019

Since this is an elementary application I'd think elementary-icon-theme would make more sense to add here.

But what's most likely the reason why this application look incorrect in KDE is that you need to install an icon theme and then configure KDE for gtk applications appropriately. See #43150 (comment) for more discussion on this topic.

I will update it to use elementary-icon-theme. With regards to the KDE settings - the thing is that I am using default Gtk settings that comes with latest KDE (Breeze setup) untouched. So, in that case I would assume it might make sense to package notes-up with default icon theme dependency. What do you think?

@kuznero
Copy link
Member Author

kuznero commented Jun 9, 2019

An update on pantheon.elementary-icon-theme - it does not give all the necessary icons. I still can see a lot of "placeholder" gtk icons (if not all). That is only fixed with full adwaita-icon-theme.

@kuznero kuznero closed this Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants