New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bloop: 1.2.5 -> 1.3.2 #62812
bloop: 1.2.5 -> 1.3.2 #62812
Conversation
I'm trying to test this, however, even with the server running I get:
Is this expected? |
The correct command binary for the client is ./bloop the blp-client is the unwrapped version. Maybe it should not be in the bin directory. I do not know if there are any best practices around this. |
I tried to update it on my side as well, and I have obtained some different sha values... For example, to get the Maybe it has changed since? The sha256 for For Caveat: I'm not very advanced in Nix, so may I miss something... PS. Thank you @Tomahna for adding bloop, very useful! |
Thank you for testing this ! Yes you're perfectly right. As I did not change the sha256, it used the value in my cache so it worked for me, but of course not for you. It should be fixed. |
I've made a few changes. That should prevent both problems from happening again. As the client has its own derivation it will not appear in the bin directory of the final derivation (only the wrapper will appear), so it should avoid the confusion. As both the client and the zsh completion have their own derivation, they will have to be rebuilt on version changes and the cache should not be hit. Please let me know, if there is a better/simpler way to do this. |
|
however:
|
If you want to launch the server from the cli you have to pass the location manually, I'm not sure how to fix that and I honestly don't intend to try as I do not use it this way. However you can use the systemd service with services.bloop.install = true or just run the command blp-server. For the second part, right now I don't know what causes it. It's not really a blocker because running the cli without a command is not really the way you want to use bloop anyway but it is definitely annoying. |
Agreed. Plus I'm not sure how it worked before the upgrade and as both are nonblockers for usage, I'd prefer the new even if somewhat quirky bloop vs nice old one even if these are new issues :) |
I checked the old version, it behaves the same. I'd need to check on a non-nix machine to see how it is actually supposed to behave. |
@FRidh maybe we can remove the work-in-progress tag ? |
btw. I've been using this PR in my manually ported nixpkgs for a while now - not quite sure who could merge it would be great if anyone did before we need to update it again :) (I've only tested bloop itself, not zsh completions) |
I would like that too. |
So I've made a few changes to get closer to the way bloop is packaged on other distributions. This fix a few problems:
Thanks to @svalaskevicius for helping me improve this ! |
This change prevents accidentally using cached version of dependencies when updating the version
just had a chance to test it (except systemd config, as I use my own setup for systemd user unit) - seems like I'm able to pass options to bloop server w/o any issues now :) |
Yay! My local nixpkg can now just point to the master :) thanks! |
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)