Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pywebpush: init at 1.9.4 #62801

Merged
merged 4 commits into from Jun 12, 2019
Merged

python3Packages.pywebpush: init at 1.9.4 #62801

merged 4 commits into from Jun 12, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

These 3 packages were needed for html5 notifications to work in HA.

Needs proper testing.

Cc: @dotlambda

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested a review from dotlambda June 7, 2019 03:26
@peterhoeg peterhoeg requested a review from FRidh as a code owner June 7, 2019 03:26
@peterhoeg
Copy link
Member Author

Doesn't break anything so should be safe to merge @dotlambda.

I must admit though, that I'm looking at moving off HA and onto OpenHAB instead as I don't like the direction of HA.

@FRidh FRidh merged commit 869f90b into NixOS:master Jun 12, 2019
@peterhoeg peterhoeg deleted the p/pywebpush branch June 13, 2019 06:57
@peterhoeg peterhoeg restored the p/pywebpush branch June 13, 2019 11:53
@peterhoeg peterhoeg deleted the p/pywebpush branch June 20, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @FRidh