Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtdutils: 1.5.2 -> 2.1.1 #62805

Merged
merged 3 commits into from Oct 15, 2019
Merged

mtdutils: 1.5.2 -> 2.1.1 #62805

merged 3 commits into from Oct 15, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 7, 2019

Motivation for this change

http://lists.infradead.org/pipermail/linux-mtd/2019-March/088267.html

And the previous releases, hardcoded version in URL I think caused
this to be missed by auto-updaters for a while now.

1.5.2, FWIW in 2015:

http://lists.infradead.org/pipermail/linux-mtd/2015-August/060723.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
mtdutils: 1.5.2 -> 2.1.0
82edce9 
http://lists.infradead.org/pipermail/linux-mtd/2019-March/088267.html

And the previous releases, hardcoded version in URL I think caused
this to be missed by auto-updaters for a while now.

1.5.2, FWIW in 2015:

http://lists.infradead.org/pipermail/linux-mtd/2015-August/060723.html
@ofborg ofborg bot requested a review from viric June 7, 2019 04:18
@mmahut
Copy link
Member

mmahut commented Jun 7, 2019

I'm getting the following during the build:

builder for '/nix/store/xfch0i7lz1dkcn0h6cr4gk85d06x3304-mtd-utils-2.1.0.drv' failed with exit code 2; last 6 log lines:
  unpacking sources
  unpacking source archive /nix/store/g1gzvibpd7n36hcgabwz3ggcj93mn38x-mtd-utils-2.1.0.tar.bz2
  source root is mtd-utils-2.1.0
  setting SOURCE_DATE_EPOCH to timestamp 1552495345 of file mtd-utils-2.1.0/include/stamp-h1
  patching sources
  sed: can't read common.mk: No such file or directory
cannot build derivation '/nix/store/hq8q9dn5v1hgq6n3xqambymjqr9lj4mv-env.drv': 1 dependencies couldn't be built
[2 built (1 failed), 63 copied (307.1 MiB), 69.3 MiB DL]
error: build of '/nix/store/hq8q9dn5v1hgq6n3xqambymjqr9lj4mv-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/62805
1 package failed to build:
mtdutils

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

@GrahamcOfBorg build mtdutils

@c0bw3b c0bw3b self-assigned this Oct 15, 2019
@c0bw3b
mtd-utils: 2.1.0 -> 2.1.1
affa543 
+ cleanup
+ enable tests and parallel building
+ add zstd support
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 15, 2019

@dtzWill I'm gently hijacking your branch to complete this pkg refresh, sorry :)

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 15, 2019

@GrahamcOfBorg build mtd-utils

@c0bw3b c0bw3b changed the title mtdutils: 1.5.2 -> 2.1.0 mtdutils: 1.5.2 -> 2.1.1 Oct 15, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 15, 2019

@GrahamcOfBorg build mtdutils

c0bw3b
c0bw3b approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and binaries runs fine

Result of nix-review pr 62805 1

1 package were build:
  • mtdutils

@c0bw3b c0bw3b merged commit 62e4a35 into NixOS:staging Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@viric viric Awaiting requested review from viric

Assignees

@c0bw3b c0bw3b

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @mmahut @c0bw3b