Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minder: init at 1.5.0 #62808

Merged
merged 2 commits into from Sep 16, 2019
Merged

minder: init at 1.5.0 #62808

merged 2 commits into from Sep 16, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 7, 2019

Motivation for this change

Mind-mapping application for Elementary OS!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

alexarice
alexarice approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested with nix-review and I can't see anything obviously wrong with the code. My only concern is that the executable file is called com.github.phase1geo.minder. I found this a bit confusing so it could be worth patching this to just be minder

mmahut
mmahut requested changes Jun 7, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output binary has a wrong name probably com.github.phase1geo.minder however it works fine.

@dtzWill dtzWill changed the title minder: init at 1.3.1 minder: init at 1.5.0 Sep 14, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Sep 16, 2019

@mmahut: should be good now, look good to you? :)

@dtzWill dtzWill requested a review from mmahut September 16, 2019 17:19
@mmahut
Copy link
Member

mmahut commented Sep 16, 2019

Looks good!

@mmahut mmahut merged commit 55eacf5 into NixOS:master Sep 16, 2019
@dtzWill dtzWill deleted the feature/minder-1.3.1 branch January 1, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @mmahut @alexarice