Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeScript: fix docstring #62831

Merged
merged 1 commit into from
Jun 9, 2019
Merged

writeScript: fix docstring #62831

merged 1 commit into from
Jun 9, 2019
+7 −2

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Jun 7, 2019

Motivation for this change

Just some minor fixes/improvements to the docstring of writeScript.

Fixes #59299

See:
b23dbb1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 7, 2019
@FRidh
Copy link
Member

FRidh commented Jun 9, 2019

commit msg is incorrect, this is about writeScriptBin

@jluttine
Copy link
Member Author

jluttine commented Jun 9, 2019

Hmm.. No..? I modified writeScript docstring.. I'm on my mobile so a bit difficult to check for 100% certain, but I don't see my commit being related to writeScriptBin in any way..

@FRidh
Copy link
Member

FRidh commented Jun 9, 2019

Ah, yes, my mistake.

@FRidh FRidh merged commit fa95878 into NixOS:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script created by writeScript run at build time
2 participants
@jluttine @FRidh