Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3471705998e7
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cbaa9a7ab917
Choose a head ref
  • 6 commits
  • 4 files changed
  • 4 contributors

Commits on Jun 4, 2019

  1. mkl: fix install_name on Darwin

    Closes #57697
    
    Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    smaret and veprbl committed Jun 4, 2019
    Copy the full SHA
    fb883a5 View commit details

Commits on Jun 6, 2019

  1. vscode: 1.34.0 -> 1.35.0

    eadwu committed Jun 6, 2019
    Copy the full SHA
    7e0b2a6 View commit details
  2. Merge pull request #62772 from eadwu/vscode/1.35.0

    vscode: 1.34.0 -> 1.35.0
    worldofpeace authored Jun 6, 2019
    Copy the full SHA
    19436d3 View commit details
  3. Copy the full SHA
    086d769 View commit details
  4. Copy the full SHA
    cf96c40 View commit details
  5. Merge pull request #57947 from smaret/fix-mkl

    mkl: fix install_name on Darwin
    veprbl authored Jun 6, 2019
    Copy the full SHA
    cbaa9a7 View commit details
8 changes: 4 additions & 4 deletions pkgs/applications/editors/vscode/vscode.nix
Original file line number Diff line number Diff line change
@@ -12,14 +12,14 @@ let
archive_fmt = if system == "x86_64-darwin" then "zip" else "tar.gz";

sha256 = {
"i686-linux" = "1xl8bk1m7d930dp7nw4770vk14cppci0ag079y8d39xqnvs24mr0";
"x86_64-linux" = "0mq6gzz7338h4ragiar55xxby0x7whcd9nvnfk46bri162bacjbg";
"x86_64-darwin" = "0pgj515k2bkpz953shmnalfw6yz8sg07jsxqk1rni9s3khrrd25h";
"i686-linux" = "1485maq7rrvi742w0zs5nnaqy2s7w4hhm0fi4n69vafncia8zyic";
"x86_64-linux" = "082725c7yzih13d4khvwz34ijwdg6yxmsxhjmpn2pqlfsg43hxsh";
"x86_64-darwin" = "1mvj63sbdcw227bi4idqcwqxds60g64spvdi2bxh5sk6g5q5df90";
}.${system};
in
callPackage ./generic.nix rec {

version = "1.34.0";
version = "1.35.0";
pname = "vscode";

executableName = "code" + lib.optionalString isInsiders "-insiders";
4 changes: 2 additions & 2 deletions pkgs/desktops/pantheon/apps/elementary-terminal/default.nix
Original file line number Diff line number Diff line change
@@ -4,15 +4,15 @@

stdenv.mkDerivation rec {
pname = "terminal";
version = "5.3.4";
version = "5.3.5";

name = "elementary-${pname}-${version}";

src = fetchFromGitHub {
owner = "elementary";
repo = pname;
rev = version;
sha256 = "08vwgd385j7cbi7c8442sjygzw9qy2phsi5lva4jaxwm8l15hk86";
sha256 = "1gd5m24digmx3sgs21ggfiqiwhgym6s1dlg1sv9mdqh5wgsa6b8f";
};

passthru = {
4 changes: 2 additions & 2 deletions pkgs/desktops/pantheon/desktop/wingpanel/default.nix
Original file line number Diff line number Diff line change
@@ -4,13 +4,13 @@

stdenv.mkDerivation rec {
pname = "wingpanel";
version = "2.2.4";
version = "2.2.5";

src = fetchFromGitHub {
owner = "elementary";
repo = pname;
rev = version;
sha256 = "17xl4l0znr91aj6kb9p0rswyii4gy8k16r9fvj7d96dd5szdp4mc";
sha256 = "15pl3km8jfmlgrrb2fcabdd0rkc849arz6sc3vz6azzpln7gxbq7";
};

passthru = {
41 changes: 29 additions & 12 deletions pkgs/development/libraries/science/math/mkl/default.nix
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{ stdenvNoCC, writeText, fetchurl, rpmextract, undmg }:
{ stdenvNoCC, writeText, fetchurl, rpmextract, undmg, darwin }:
/*
For details on using mkl as a blas provider for python packages such as numpy,
numexpr, scipy, etc., see the Python section of the NixPkgs manual.
*/
stdenvNoCC.mkDerivation rec {
stdenvNoCC.mkDerivation (rec {
name = "mkl-${version}";
version = "${date}.${rel}";
date = "2019.3";
@@ -21,7 +21,13 @@ stdenvNoCC.mkDerivation rec {
sha256 = "13rb2v2872jmvzcqm4fqsvhry0j2r5cn4lqql4wpqbl1yia2pph6";
});

buildInputs = if stdenvNoCC.isDarwin then [ undmg ] else [ rpmextract ];
nativeBuildInputs = if stdenvNoCC.isDarwin
then
[ undmg
darwin.cctools
]
else
[ rpmextract ];

buildPhase = if stdenvNoCC.isDarwin then ''
for f in Contents/Resources/pkg/*.tgz; do
@@ -41,6 +47,7 @@ stdenvNoCC.mkDerivation rec {
cp -r compilers_and_libraries_${version}/licensing/mkl/en/license.txt $out/lib/
cp -r compilers_and_libraries_${version}/mac/compiler/lib/* $out/lib/
cp -r compilers_and_libraries_${version}/mac/mkl/lib/* $out/lib/
cp -r compilers_and_libraries_${version}/mac/tbb/lib/* $out/lib/
'' else ''
mkdir -p $out/lib
@@ -51,18 +58,22 @@ stdenvNoCC.mkDerivation rec {
cp license.txt $out/lib/
'';

# fixDarwinDylibName fails for libmkl_cdft_core.dylib because the
# larger updated load commands do not fit. Use install_name_tool
# explicitly and ignore the error.
postFixup = stdenvNoCC.lib.optionalString stdenvNoCC.isDarwin ''
for f in $out/lib/*.dylib; do
install_name_tool -id $out/lib/$(basename $f) $f || true
done
install_name_tool -change @rpath/libiomp5.dylib $out/lib/libiomp5.dylib $out/lib/libmkl_intel_thread.dylib
install_name_tool -change @rpath/libtbb.dylib $out/lib/libtbb.dylib $out/lib/libmkl_tbb_thread.dylib
install_name_tool -change @rpath/libtbbmalloc.dylib $out/lib/libtbbmalloc.dylib $out/lib/libtbbmalloc_proxy.dylib
'';

# Per license agreement, do not modify the binary
dontStrip = true;
dontPatchELF = true;

# Since these are unmodified binaries from Intel, they do not depend on stdenv
# and we can make them fixed-output derivations for cache efficiency.
outputHashAlgo = "sha256";
outputHashMode = "recursive";
outputHash = if stdenvNoCC.isDarwin
then "0rwm46v9amq2clm6wxhr98zzbafr485dz05pihlqsbrbabmlfw30"
else "101krzh2mjbfx8kvxim2zphdvgg7iijhbf9xdz3ad3ncgybxbdvw";

meta = with stdenvNoCC.lib; {
description = "Intel Math Kernel Library";
longDescription = ''
@@ -76,4 +87,10 @@ stdenvNoCC.mkDerivation rec {
platforms = [ "x86_64-linux" "x86_64-darwin" ];
maintainers = [ maintainers.bhipple ];
};
}
} // stdenvNoCC.lib.optionalAttrs stdenvNoCC.isLinux {
# Since on Linux binaries are unmodified, we can make them
# fixed-output derivations.
outputHashAlgo = "sha256";
outputHashMode = "recursive";
outputHash = "101krzh2mjbfx8kvxim2zphdvgg7iijhbf9xdz3ad3ncgybxbdvw";
})