Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.13.6 -> 1.13.7 (CVE-2019-11245) #62818

Merged
merged 1 commit into from Jun 7, 2019
Merged

kubernetes: 1.13.6 -> 1.13.7 (CVE-2019-11245) #62818

merged 1 commit into from Jun 7, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Jun 7, 2019

Motivation for this change

To fix regression introduced in v1.13.6. Also referred to as: CVE-2019-11245
See: kubernetes/kubernetes#78308

relates to #62816

Tests run clean locally:

$ nix-build ./nixos/release.nix -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode
/nix/store/g557kf9qgzdy509f8ia50pkvql4g334w-vm-test-run-kubernetes-rbac-singlenode
/nix/store/c6n4966w9cpfsaf1gqn4z9mb09laifiy-vm-test-run-kubernetes-rbac-multinode
/nix/store/ww40jwpp8xdszy0ixcfa532wdjdlabjx-vm-test-run-kubernetes-dns-singlenode
/nix/store/1sx28xlidwr9s86zwmbkz25qnhil1155-vm-test-run-kubernetes-dns-multinode

ping @srhb

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker June 7, 2019 08:50
fpletz
fpletz approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport!

@fpletz fpletz merged commit 4f2244c into NixOS:release-19.03 Jun 7, 2019
@fpletz fpletz added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 8.has: package (update) labels Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanot @fpletz