Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.34.0 -> 1.35.0 #62772

Merged
merged 1 commit into from
Jun 6, 2019
Merged

vscode: 1.34.0 -> 1.35.0 #62772

merged 1 commit into from
Jun 6, 2019
+4 −4

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jun 6, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@eadwu
vscode: 1.34.0 -> 1.35.0

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 76AA3F9F2BD3E3A0
Verified
Learn about vigilant mode
7e0b2a6
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 6, 2019
mmahut
mmahut approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build evals
  • run nix-review without any failures
  • run and tested the binaries

Sorry, something went wrong.

@worldofpeace worldofpeace merged commit 19436d3 into NixOS:master Jun 6, 2019
@eadwu eadwu deleted the vscode/1.35.0 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @mmahut @worldofpeace