Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/docker-tools: check layer sharing with buildLayeredImage #62773

Merged
merged 1 commit into from
Jun 8, 2019
Merged

nixos/tests/docker-tools: check layer sharing with buildLayeredImage #62773

merged 1 commit into from
Jun 8, 2019
+14 −0

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jun 6, 2019

Motivation for this change

This adds a test that verifies that buildLayeredImage leads to shared layers. The test should always succeed, since at least a layer containing the glibc leaf is shared between the images. The test succeeds with #62719, but fails before that PR.

Adapted from grahamc's blog post on layered Docker images in Nix:

https://grahamc.com/blog/nix-and-layered-docker-images

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@danieldk
nixos/tests/docker-tools: check layer sharing with buildLayeredImage

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
3b0d5b5 
Adapted from grahamc's blog post on layered Docker images in Nix:

https://grahamc.com/blog/nix-and-layered-docker-images
@danieldk
Copy link
Contributor Author

danieldk commented Jun 6, 2019

@GrahamcOfBorg test docker-tools

@danieldk
Copy link
Contributor Author

danieldk commented Jun 6, 2019

@nlewo this is the test that corresponds to #62719

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 6, 2019
@nlewo nlewo merged commit 0e28092 into NixOS:master Jun 8, 2019
@nlewo
Copy link
Member

nlewo commented Jun 8, 2019

Locally tested and backported to 19.03: 5f97866
Thx!

@danieldk danieldk deleted the docker-shared-layer-test branch July 6, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @nlewo