Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-x11: Put absolute library paths into ICD config files. #62870

Merged
merged 1 commit into from Jul 10, 2019
Merged

nvidia-x11: Put absolute library paths into ICD config files. #62870

merged 1 commit into from Jul 10, 2019

Conversation

ambrop72
Copy link
Contributor

@ambrop72 ambrop72 commented Jun 8, 2019

Motivation for this change

If absolute library paths are used then use of RUNPATH or LD_LIBRARY_PATH becomes unnecessary. See the discussion here: #60985 (comment)

This will allow removing addOpenGLRunpath from vulkan-loader and similar things.

Things done

Checked that with NVidia all of the following still work, including 32-bit program on 64-bit system: glxinfo, glxgears, es2_info, es2gears,vulkan-info, opencl-info.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ambrop72 ambrop72 mentioned this pull request Jun 8, 2019
Merged
10 tasks
@ambrop72 ambrop72 mentioned this pull request Jun 26, 2019
Merged
10 tasks
@ambrop72
Copy link
Contributor Author

ambrop72 commented Jul 1, 2019

Why is this not being merged?

@ambrop72
Copy link
Contributor Author

ambrop72 commented Jul 10, 2019 •
edited

Why is this not merged? @matthewbauer @baracoder

@matthewbauer matthewbauer merged commit 87ec262 into NixOS:master Jul 10, 2019
@ambrop72
Copy link
Contributor Author

Thanks.

@ambrop72 ambrop72 mentioned this pull request Jul 16, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ambrop72 @matthewbauer