nixos/documentation: nixos-help: use w3m(1) by default #62891
Merged
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/nixos-documentation-nixos-help-use-w3m-1-by-default/3124/6 |
ofborg
bot
added
6.topic: nixos
vcunat
reviewed
Jun 9, 2019
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/nixos-documentation-nixos-help-use-w3m-1-by-default/3124/7 |
ofborg
bot
added
10.rebuild-darwin: 0
It is referenced in various places, but does not work out of the box: $ nixos-help /run/current-system/sw/bin/nixos-help: unable to start a web browser; please set $BROWSER In the user-hidden fallbacks to xdg-open(1) and w3m(1), `nixos-help` expects tools to be deliberately installed by users. For default installations and new users in general, this is unlikely to be the case. Conversely, chances to use `nixos-help` are even higher in such cases. Use w3m-nographics by default to ensure documentation is always available. The documentation browser on ttyS8 already does so, but is not accessible in every installation, e.g. VMs with only ttyS0 and SSH available. This obsoletes including it in the base profile's systemPackages, so remove the @todo as done.
jtojnar
force-pushed
the
nixos-documentation-nixos-help-use-w3m-1-by-default
branch
from
59451f1 to
03d6c40
Compare
10 tasks
jtojnar
deleted the
nixos-documentation-nixos-help-use-w3m-1-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sent by Discourse: https://discourse.nixos.org/t/nixos-documentation-nixos-help-use-w3m-1-by-default/3124
Motivation for this change
It is referenced in various places, but does not work out of the box:
In the user-hidden fallbacks to xdg-open(1) and w3m(1),
nixos-helpexpects tools to be deliberately installed by users.
For default installations and new users in general, this is unlikely to
be the case. Conversely, chances to use
nixos-helpare even higherin such cases.
Use w3m-nographics by default to ensure documentation is always
available. The documentation browser on ttyS8 already does so, but is
not accessible in every installation, e.g. VMs with only ttyS0 and SSH
available.
This obsoletes including it in the base profile's systemPackages,
so remove the @todo as done.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)