Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libclc: 2017-11-29 -> 2019-06-09 #62890

Merged
merged 1 commit into from Feb 14, 2020
Merged

Conversation

athas
Copy link
Contributor

@athas athas commented Jun 9, 2019

Motivation for this change

The old version does not compile at all with the current default LLVM in Nixpkgs. This one does.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build libclc

@aanderse
Copy link
Member

@athas can you please address the build failure?

@athas
Copy link
Contributor Author

athas commented Aug 31, 2019

I don't know why it's trying to build for aarch64. The targets libclc lists as supported are all NVIDIA and AMD GPU architectures. Is there a way to find out whether the current libclc used to build on aarch64? (It certainly doesn't now - it does not build on anything.)

@yorickvP
Copy link
Contributor

platforms.x86_64?

@athas
Copy link
Contributor Author

athas commented Oct 2, 2019

If the aarch64 failure is a blocker for 19.09 (note the current libclc does not work at all on any platform), I recommend just disabling aarch64 (no idea how). I have no way to debug it, since I do not have access to an aarch64 machine.

@athas athas force-pushed the libclc-2019-06-09 branch 2 times, most recently from c81d074 to b4d2f3b Compare October 8, 2019 14:13
@athas
Copy link
Contributor Author

athas commented Oct 8, 2019

I managed to find an aarch64 machine and fix the issue, I think.

@athas
Copy link
Contributor Author

athas commented Oct 8, 2019

Relevant for #68361.

@aanderse
Copy link
Member

aanderse commented Oct 12, 2019

@GrahamcOfBorg build libclc

@aanderse
Copy link
Member

@athas please rebase on master and remove the broken bit.

@athas
Copy link
Contributor Author

athas commented Oct 13, 2019

Done!

@aanderse
Copy link
Member

@athas looks like there are still issues.

@athas
Copy link
Contributor Author

athas commented Oct 13, 2019

Looks like some of my changes got lost in the rebase. Should work now.

@aanderse
Copy link
Member

@athas looks like something else went wrong with your push: undefined variable 'clang-unwrapped'

@athas
Copy link
Contributor Author

athas commented Oct 13, 2019

Alright, check it out now.

@aanderse
Copy link
Member

@matthewbauer are you familiar with this library at all? If so... care to take over from here? 😄

@athas
Copy link
Contributor Author

athas commented Feb 8, 2020

Any news here? As stated in the original PR, the current libclc simply doesn't work (and is barely used for anything; my motivation is eventually fixing Mesa), so this cannot possibly go wrong.

@vcunat
Copy link
Member

vcunat commented Feb 14, 2020

Let's re-check the builds.
@GrahamcOfBorg build libclc

@vcunat
Copy link
Member

vcunat commented Feb 14, 2020

It seems a bit suspicious to use wrapped bin/clang++ and unwrapped bin/clang, but if it seems to work, it's surely better than a package that doesn't even build.

@danbst danbst merged commit a0b1547 into NixOS:master Feb 14, 2020
vcunat added a commit that referenced this pull request Feb 14, 2020
vcunat added a commit that referenced this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants