clinfo: init at 2.2.18.04.06 #62872
Merged
clinfo: init at 2.2.18.04.06 #62872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aw man I was looking for this the other day, and was unhappy to find opencl-info seemed the best available. Thanks for the good timing! ;). |
jtojnar
reviewed
Jun 13, 2019
pkgs/tools/system/clinfo/default.nix
Outdated
| pname = "clinfo"; | ||
| version = "2.2.18.04.06"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
You should use fetchFromGitHub here.
jtojnar
reviewed
Jun 13, 2019
pkgs/tools/system/clinfo/default.nix
Outdated
|
|
||
| NIX_LDFLAGS = [ "-lOpenCL" ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
makeFlags = [ "PREFIX=${placeholder "out"}" ]; should allow you to get rid of the custom installPhase.
There was a problem hiding this comment.
You can also just pass PREFIX=$(out) in this case, and Make will expand the environment variable $out.
jtojnar
reviewed
Jun 13, 2019
|
Thanks for the review; I have fixed everything that was pointed out. |
jtojnar
approved these changes
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
clinfois the standard tool for querying the state of OpenCL. Nixpkgs already hasopencl-info, but it's older and unmaintained.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)