Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emacs packages update: 2019-06-06 #62784

Merged
merged 3 commits into from Jun 9, 2019
Merged

Emacs packages update: 2019-06-06 #62784

merged 3 commits into from Jun 9, 2019

Conversation

rasendubi
Copy link
Member

Motivation for this change

Update elpa-packages, melpa-packages, melpa-stable-packages.

Checked with nix-instantiate. Going to test with my emacs setup tomorrow.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @peti

@rasendubi rasendubi changed the title Emacs packages 2019 06 06 Emacs packages update: 2019-06-06 Jun 6, 2019
@rasendubi rasendubi mentioned this pull request Jun 6, 2019
Merged
10 tasks
rycee
rycee approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged this PR into my 19.03 branch yesterday and have used it all day without issues.

(The lsp-java module has improved quite a lot but my config needed a few adjustments due to changed option names.)

@rasendubi
Copy link
Member Author

I'm running this update on my system for a day, too. Seems to work fine with my emacs setup.

I believe it is safe to merge.

@matthewbauer matthewbauer merged commit a592a90 into NixOS:master Jun 9, 2019
@rasendubi rasendubi mentioned this pull request Jun 11, 2019
Merged
10 tasks
@rasendubi
Copy link
Member Author

During this update, there was an update script invocation error which resulted in melpa-stable-packages to also include all the unstable packages.

I have re-run the script correctly, and #62995 removes all the unstable packages that were accidentally included.

@rasendubi rasendubi mentioned this pull request Aug 9, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee approved these changes

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rasendubi @rycee @matthewbauer