Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.semshi: init at 2018-12-05 #62787

Merged
merged 1 commit into from Jun 7, 2019
Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 6, 2019

Motivation for this change

Add nice python QoL neovim plugin. It's semantically aware so it's a bit smarter about highlighting than just a regex based syntax highlighter.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh /nix/store/70c3jm94h20wdp8lyl8dbr2gqm0986gr-vimplugin-semshi-2018-12-05
/nix/store/70c3jm94h20wdp8lyl8dbr2gqm0986gr-vimplugin-semshi-2018-12-05 117.3K

@teto
Copy link
Member

teto commented Jun 7, 2019

thanks for the contribution. does it works out of the box ? or must I setup some commands ?
I wonder about the dependencies = [ python3.pkgs.pynvim ]; efficiency since neovim must have been configured with python3 setup beforehand. I believe we reah the limit of the vim plugin system in nix.

@jonringer
Copy link
Contributor Author

@teto i used it in my overlay without that line and it seems to work for neovim, i can do some more investigation if its actually needed

@teto
Copy link
Member

teto commented Jun 7, 2019

why did you add it then ? it might be best to remove it. we don't have a good way to specify this kind of dependency anyway (I am doing some work in that direction but it won't be enough).

btw, on the semantic analysis topic: neovim/neovim#10124

@jonringer
Copy link
Contributor Author

jonringer commented Jun 7, 2019

It was part of the installation instructions on his page https://github.com/numirias/semshi#installation . It looks like the neovim wrapper will always include the pynvim packages, so it's not necessary. I would still like to leave the description so that people know it doesnt work with vanilla vim though.

Interesting link, looks super promising.

@jonringer
Copy link
Contributor Author

Meh, just decided to remove all the changes to overrides.nix, doesn't really make sense to have all the packages insert an entry just for a description.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be neat to have something similar to disable = !isPy3k in pythonPackages in the future. There are more and more plugins that will only work for neovim, not for vim.

@timokau timokau merged commit 939a652 into NixOS:master Jun 7, 2019
@jonringer jonringer deleted the add_semshi branch July 9, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants