glrnvim: init at 0.1.1 #62785
Closed
glrnvim: init at 0.1.1 #62785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Not sure this package is all that useful. It just runs neovim inside the terminal (alacritty, which does the GPU acceleration).
See: beeender/glrnvim#3
I'm not sure whether we have a policy for what packages to include, whether we want everything or not.
| pname = "glrnvim"; | ||
| version = "0.1.1"; | ||
|
|
||
| src = builtins.fetchTarball { |
There was a problem hiding this comment.
For GitHub sources you can use fetchFromGitHub.
|
|
||
| meta = with stdenv.lib; { | ||
| description = "A GPU-accelerated neovim GUI"; | ||
| homepage = https://github.com/beeender/glrnvim; |
There was a problem hiding this comment.
Suggested change
| homepage = https://github.com/beeender/glrnvim; | |
| homepage = "https://github.com/beeender/glrnvim"; |
We're probably going to deprecate unquoted URL syntax once RFC 45 is approved.
Makes sense. I'll put in my NUR instead, then. |
| @@ -20574,6 +20574,8 @@ in | |||
|
|
|||
| neovim-qt = libsForQt5.callPackage ../applications/editors/neovim/qt.nix { }; | |||
|
|
|||
| glrnvim = libsForQt5.callPackage ../applications/editors/neovim/glrnvim { }; | |||
There was a problem hiding this comment.
glrnvim = callPackage ../applications/editors/neovim/glrnvim { };
Also it's not a QT package, so you should just call the top-level callPackage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)