Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support edition of all manœuvres in a flight plan #2197

Merged
merged 9 commits into from
Jun 9, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jun 9, 2019

  • Remove ReplaceLast everywhere and use Replace instead.
  • Remove the enabled boolean from the UI: all burn editors are always enabled.
  • Change the flight planner to handle all burn editors identically.

Fix #1936.

pleroy added 8 commits June 6, 2019 20:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
public bool Render(string header,
bool enabled,
double? actual_final_time = null) {
public bool Render(string header, double final_time) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should retain some sort of enabled=false on anomalous manoeuvres: editing them would happen without seeing any resulting effects.
A manoeuvre cannot be anomalous because of its own parameters, except for its timing; could it make sense to have the timing enabled on all manoeuvres, but the other parameters only enabled on non-anomalous ones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. It's also a good visual feedback. Will do.

@eggrobin eggrobin added the LGTM label Jun 9, 2019
@pleroy pleroy merged commit b2a80b5 into mockingbirdnest:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Multiple nodes editing
2 participants