Scale oil refinery edge distance up by map size #7514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The setting description is misleading. It also applies to Oil Rigs. |
|
Hm true, the setting value is also used for oil rigs, but I did not change that check to use the same scaling. I should do that too. |
nielsmh
force-pushed
the
ind-mapedge-check
branch
from
82796cb
to
4ed36eb
Compare
|
Should |
|
I looked at that function and decided it's not going to do what I want. With a setting value of 32, if MapSizeX is 512 the threshold should be doubled in X axis independent of the Y axis dimension. |
LordAro
reviewed
Jun 6, 2019
LordAro
reviewed
Jun 6, 2019
nielsmh
force-pushed
the
ind-mapedge-check
branch
from
4ed36eb
to
28b8ab7
Compare
Also scales oil rig distance up, since they use the same algorithm.
nielsmh
force-pushed
the
ind-mapedge-check
branch
from
28b8ab7
to
78fc910
Compare
LordAro
approved these changes
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing on a huge map and got annoyed at how relatively close to the edges oil refineries had to be built. I think it makes sense to scale the distance up on larger maps.