Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reredirect: init at 0.2 #62868

Merged
merged 1 commit into from Dec 30, 2019
Merged

reredirect: init at 0.2 #62868

merged 1 commit into from Dec 30, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jun 8, 2019 •
edited

Motivation for this change

reredirect - A tool to dynamically redirect outputs of a running program

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Jun 10, 2019

LGTM, haven't done much with it but builds and runs in at least basic invocation.

Neat utility, thanks!

@tobim
Copy link
Contributor Author

tobim commented Jun 10, 2019

Neat utility, thanks!

Yeah, it's very useful for updating a piece of software at the consuming end of a pipe.

aanderse
aanderse requested changes Aug 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a neat tool. I look forward to trying it out at some point.

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/reredirect/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/reredirect/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/reredirect/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/reredirect/default.nix Outdated Show resolved Hide resolved
@tobim tobim force-pushed the pkgs/reredirect branch 2 times, most recently from e8baaa3 to 9e6ee7a Compare September 2, 2019 04:29
@aanderse
Copy link
Member

aanderse commented Sep 3, 2019

@tobim I'm having a trouble with the relink binary provided:

nixpkgs on  HEAD [?] 
❯ /nix/store/0qppcyzvfbr7sryrrhq6v8albgy5f6ry-reredirect-0.2/bin/relink 31660
/nix/store/0qppcyzvfbr7sryrrhq6v8albgy5f6ry-reredirect-0.2/bin/relink: line 46: reredirect: command not found

@tobim
Copy link
Contributor Author

tobim commented Sep 3, 2019

relink is a convenience script that calls reredirect. I could add a substituteInPlace in postFixup to turn the call into an absolute path. Is this commonly done for other packages that provide scripts?

@aanderse
Copy link
Member

@tobim sorry this dropped off my radar. That sounds reasonable.

@aanderse
Copy link
Member

@tobim looks like the bot is having some problems. Please resolve to continue.

@tobim
Copy link
Contributor Author

tobim commented Oct 31, 2019

I don't understand what is wrong here, when I try to run the meta checks my system runs out of memory. @aanderse can you give me a pointer?

@aanderse
Copy link
Member

@tobim yeah not sure about that one. I'm sure someone on IRC or discourse could probably get you settled real quick, though.

@Lassulus
Copy link
Member

@GrahamcOfBorg eval

@tobim
Copy link
Contributor Author

tobim commented Dec 29, 2019

@aanderse the meta check issue is resolved.

@aanderse aanderse merged commit 0b960bc into NixOS:master Dec 30, 2019
@aanderse
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobim @dtzWill @aanderse @Lassulus