jellyfin: add bundled libraries to LD_LIBRARY_PATH #61668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build nixosTests.jellyfin |
matthewbauer
reviewed
Jun 5, 2019
| @@ -28,8 +44,8 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| makeWrapper "${dotnet-sdk}/bin/dotnet" $out/bin/jellyfin \ | |||
| --prefix LD_LIBRARY_PATH : "${stdenv.lib.makeLibraryPath [ | |||
| sqlite | |||
| ]}" \ | |||
| sqlite fontconfig freetype stdenv.cc.cc.lib | |||
There was a problem hiding this comment.
Are you sure these are needed? I would think it should at least link to the cc lib correctly.
There was a problem hiding this comment.
The issue isn't with the dotnet executable per-se, but with a bundled library which, because we download the pre-compiled version, isn't properly linked. Here's what I get when I do ldd opt/jellyfin/runtimes/linux-x64/native/libSkiaSharp.so from a pure nix-shell:
linux-vdso.so.1 (0x00007ffe6fd6b000)
libpthread.so.0 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libpthread.so.0 (0x00007f2208f48000)
libdl.so.2 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libdl.so.2 (0x00007f2208f43000)
libfreetype.so.6 => not found
libfontconfig.so.1 => not found
libstdc++.so.6 => not found
libm.so.6 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libm.so.6 (0x00007f2208dad000)
libgcc_s.so.1 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libgcc_s.so.1 (0x00007f2208b95000)
libc.so.6 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libc.so.6 (0x00007f22089df000)
/nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib64/ld-linux-x86-64.so.2 (0x00007f220995c000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Without this, we have this error:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)