Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/systemd: enable systemd-tmpfiles-setup and -clean for user sessions #62813

Merged
merged 1 commit into from
Jun 14, 2019
Merged

nixos/systemd: enable systemd-tmpfiles-setup and -clean for user sessions #62813

merged 1 commit into from
Jun 14, 2019
+3 −0

Conversation

peterhoeg
Copy link
Member

Motivation for this change

We currently have support for system tmpfiles but not the user equivalents. This PR only enables the units so you can stick files in ~/.config/user-tmpfiles.d and have them work as expected.

A next step would be to:

  1. create systemd.user.tmpfiles.rules similar to systemd.tmpfiles.rules
  2. patch systemd to look into /etc/user-tmpfiles.d instead of /usr/share/user-tmpfiles.d
  3. write out systemd.user.tmpfiles.rules

Cc: @infinisil @fpletz

Works fine here with files in ~/.config/user-tmpfiles.d

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 7, 2019
@peterhoeg peterhoeg mentioned this pull request Jun 7, 2019
Closed
@flokli
Copy link
Contributor

flokli commented Jun 7, 2019

@peterhoeg might want to try patching systemd on top of #61321.

@peterhoeg
Copy link
Member Author

The update to 242 is unrelated - we are simply pulling in a few units that upstream has been distributing for a number of releases.

@flokli
Copy link
Contributor

flokli commented Jun 14, 2019

👍

@flokli flokli merged commit e0818a1 into NixOS:master Jun 14, 2019
@peterhoeg peterhoeg deleted the f/units branch June 14, 2019 23:39
@flokli
Copy link
Contributor

flokli commented Jun 15, 2019

@peterhoeg how are the units supposed to be activated?

@peterhoeg
Copy link
Member Author

They get activated for me automatically on login. The ``--setup``` unit cannot be activated manually.

@peterhoeg peterhoeg restored the f/units branch June 17, 2019 06:06
@flokli
Copy link
Contributor

flokli commented Jun 17, 2019 •
edited
Loading

@peterhoeg we might want to add a NixOS test for that. Could you do that?

In addition, maybe home-manager should trigger user-tmpfiles creation on activation, similar to https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/system/activation/switch-to-configuration.pl#L412

cc @rycee

@peterhoeg peterhoeg deleted the f/units branch June 20, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @flokli @dasJ