Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jgmenu: 1.1 -> 3.0 #62821

Merged
merged 1 commit into from Jun 9, 2019
Merged

jgmenu: 1.1 -> 3.0 #62821

merged 1 commit into from Jun 9, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 7, 2019 •
edited

Motivation for this change

Update to 3.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jun 7, 2019

./result/bin/jgmenu_run fails for me with ./result/bin/jgmenu_run: line 73: exec: jgmenu: not found.

@romildo
Copy link
Contributor Author

romildo commented Jun 8, 2019

./result/bin/jgmenu_run fails for me with ./result/bin/jgmenu_run: line 73: exec: jgmenu: not found.

It expects to find jgmenu in PATH. It should work when the package is installed.

@romildo
Copy link
Contributor Author

romildo commented Jun 8, 2019

./result/bin/jgmenu_run fails for me with ./result/bin/jgmenu_run: line 73: exec: jgmenu: not found.

It expects to find jgmenu in PATH. It should work when the package is installed.

The shell script jgmenu_run originally already changes the PATH environment variable to include $out/lib/jgmenu. I am fixing this issue by also adding $out/bin to it.

@Ma27
Copy link
Member

Ma27 commented Jun 9, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit eb09ec0 into NixOS:master Jun 9, 2019
@Ma27
Copy link
Member

Ma27 commented Jun 9, 2019

@romildo thanks!

@romildo romildo deleted the upd.jgmenu branch June 10, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @Ma27