New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent fooling PerformanceObserver.supportedEntryTypes #17242
Conversation
There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
This test guarantees that official entries claimed to be supported by an implementation are actually supported. It repeats checks from respective specifications/tests providing those definitions. More precisely, it follows: https://github.com/web-platform-tests/wpt/blob/master/navigation-timing/supported_navigation_type.window.js NOTE: I probably need to rewrite my test with .window.js and .any.js ... |
/cc @npm1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the need to account for window/worker differences (this is fine as a window test though).
Also look at Taskcluster failures before merging. |
9926197
to
e729934
Compare
* Prevent fooling PerformanceObserver.supportedEntryTypes * Split between any and window * Long task is only on Window * CRLF -> LF
This intended to help resolve w3c/performance-timeline#117