Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent fooling PerformanceObserver.supportedEntryTypes #17242

Merged
merged 4 commits into from Jun 13, 2019
Merged

Prevent fooling PerformanceObserver.supportedEntryTypes #17242

merged 4 commits into from Jun 13, 2019

Conversation

plehegar
Copy link
Member

@plehegar plehegar commented Jun 9, 2019

This intended to help resolve w3c/performance-timeline#117

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@plehegar
Copy link
Member Author

plehegar commented Jun 9, 2019

This test guarantees that official entries claimed to be supported by an implementation are actually supported. It repeats checks from respective specifications/tests providing those definitions.

More precisely, it follows:

https://github.com/web-platform-tests/wpt/blob/master/navigation-timing/supported_navigation_type.window.js
https://github.com/web-platform-tests/wpt/blob/master/resource-timing/supported_resource_type.any.js
https://github.com/web-platform-tests/wpt/blob/master/user-timing/supported-usertiming-types.any.js
https://github.com/web-platform-tests/wpt/blob/master/paint-timing/supported-paint-type.window.js
https://github.com/web-platform-tests/wpt/blob/master/longtask-timing/supported-longtask-types.window.js

NOTE: I probably need to rewrite my test with .window.js and .any.js ...

@yoavweiss
Copy link
Contributor

/cc @npm1

npm1
npm1 reviewed Jun 12, 2019
View reviewed changes
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the need to account for window/worker differences (this is fine as a window test though).

timing-entrytypes-registry/registry.html Outdated Show resolved Hide resolved
timing-entrytypes-registry/registry.html Outdated Show resolved Hide resolved
npm1
npm1 approved these changes Jun 12, 2019
View reviewed changes
timing-entrytypes-registry/registry.any.js Outdated Show resolved Hide resolved
@npm1
Copy link
Contributor

npm1 commented Jun 12, 2019

Also look at Taskcluster failures before merging.

@plehegar plehegar merged commit 2d2b6ee into master Jun 13, 2019
@plehegar plehegar deleted the timing-entrytypes-registry branch June 13, 2019 01:05
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
@plehegar
Prevent fooling PerformanceObserver.supportedEntryTypes (#17242)
b275461 
* Prevent fooling PerformanceObserver.supportedEntryTypes

* Split between any and window

* Long task is only on Window

* CRLF -> LF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npm1 npm1 npm1 approved these changes

Assignees

@npm1 npm1

Labels
do not merge yet status:needs-reviewers timing-entrytypes-registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

supportedEntryTypes API has some issues
4 participants
@plehegar @wpt-pr-bot @yoavweiss @npm1