Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "alsaLib: 1.1.8 -> 1.1.9" #62895

Merged
merged 1 commit into from Jun 9, 2019
Merged

Revert "alsaLib: 1.1.8 -> 1.1.9" #62895

merged 1 commit into from Jun 9, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jun 9, 2019 •
edited

Motivation for this change

This reverts commit 2a5923a.

Breaks sound, at least for some people.
https://discourse.nixos.org/t/no-sound-on-unstable/3130

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Revert "alsaLib: 1.1.8 -> 1.1.9"
dcf3487 
This reverts commit 2a5923a.

Breaks sound, at least for some people.
https://discourse.nixos.org/t/no-sound-on-unstable/3130
@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

Is there some kind of "evidence" that this was the problematic change (and reverting will fix the regression)?

@timokau
Copy link
Member Author

timokau commented Jun 9, 2019

At least for me, I git-bisected it to that commit. In addition I'm currently rebuilding my system on top of this PR to make sure.

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

I believe the rebuild amount is OK for master, given that it fixes a regression.

@timokau
Copy link
Member Author

timokau commented Jun 9, 2019

Thanks for your opinion. It is a pretty big rebuild, but I was able to rebuild my base system in reasonable time (30min). Reverting the commit did fix the issue, so I agree the rebuild is worth it.

@timokau timokau merged commit bbb3801 into NixOS:master Jun 9, 2019
@timokau timokau deleted the alsalib-revert branch June 9, 2019 14:17
@timokau timokau mentioned this pull request Jun 9, 2019
Merged
@mtrsk
Copy link
Member

mtrsk commented Jun 9, 2019

I can confirm this solution solved my audio issue.

@fpletz
Copy link
Member

fpletz commented Jun 9, 2019 •
edited

Please revert this revert again as dacc02f (and a similar commit from me on staging) fixes this. Probably not on unstable channel yet.

@fpletz
Copy link
Member

fpletz commented Jun 9, 2019

Verified that @aristidb's fix wasn't on unstable yet. Reverted this and pushed to master to not cause any more unnecessary rebuilds.

fpletz added a commit that referenced this pull request Jun 9, 2019
@fpletz
Revert "Revert "alsaLib: 1.1.8 -> 1.1.9" (#62895)"
b7b92bc 
This reverts commit bbb3801.

The issue in pulseaudio was fixed by dacc02f.

cc #62895
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/no-sound-on-19-09/4377/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timokau @vcunat @mtrsk @fpletz @nixos-discourse