Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm_7: skip failing X86 test cases on armv7l #62894

Merged
merged 1 commit into from Jun 11, 2019
Merged

llvm_7: skip failing X86 test cases on armv7l #62894

merged 1 commit into from Jun 11, 2019

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Jun 9, 2019

fixes #57472

Things done

tested OK on armv7l

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@womfoo womfoo requested a review from matthewbauer as a code owner June 9, 2019 13:38
@dtzWill
Copy link
Member

dtzWill commented Jun 10, 2019

LGTM, do we know why they fail? (And does LLVM 8 need similar change or do the tests pass there?)

@matthewbauer matthewbauer merged commit 4e74a13 into NixOS:master Jun 11, 2019
@IreneKnapp
Copy link
Contributor

Re: why they fail, as far as I could tell it was something about DWARF annotations being generated for the wrong architecture. I don't have a clear understanding of what the test is doing; this is just based on reading the error.

@expipiplus1 expipiplus1 mentioned this pull request Jul 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

llvm-7.0.1 fails tests on armv7
4 participants
@womfoo @dtzWill @IreneKnapp @matthewbauer