Skip to content

pythonPackages.neuron: fix for darwin #62875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2019
Merged

pythonPackages.neuron: fix for darwin #62875

merged 2 commits into from
Jun 9, 2019
+8 −1

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 9, 2019

Motivation for this change

Fix build on darwin by un-compensating for some of the darwin quirks the neuron source is expecting but we don't have.

Also disable for non-x86 as the source claims #error "This code has only been tested on x86 and powerpc platforms."

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

risicle added 2 commits June 8, 2019 23:51
@risicle
pythonPackages.neuron: fix for darwin
7092253 
un-compensate for some of the darwin quirks the neuron
source is expecting
@risicle
pythonPackages.neuron: restrict to x86 platforms
ffcfc4e
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 9, 2019
@risicle risicle changed the title Ris neuron darwin pythonPackages.neuron: fix for darwin Jun 9, 2019
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 9, 2019
@veprbl
Copy link
Member

veprbl commented Jun 9, 2019

@GrahamcOfBorg build python27Packages.neuron python37Packages.neuron

@FRidh FRidh merged commit 48c8756 into NixOS:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @veprbl @FRidh