Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind: fix build on armv6l #62873

Merged
merged 1 commit into from Jun 9, 2019
Merged

bind: fix build on armv6l #62873

merged 1 commit into from Jun 9, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

bind 9.14 cannot be built on armv6l (and older) because it requires the YIELD instruction. This requirement was later removed upstream, but this commit is not included in 9.14. See https://gitlab.isc.org/isc-projects/bind9/issues/981

This breaks NixOS on armv6l because the host command, which is part of bind, is installed by default.

Things done

Backport the upstream patch that fixes the build on armv6l.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from peti June 8, 2019 23:26
@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

@GrahamcOfBorg build bind

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

Oh, I see darwin has been broken since the 9.12 -> 9.14 update. It was hard to detect beforehand... I had to force a Hydra build attempt now, because of the bad state Hydra's Darwin is in.

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

Oh, when we have these, why not try them, even if this PR seems very unlikely to break them:
@GrahamcOfBorg test bind

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

I fixed darwin on master now (creating this trivial merge conflict), but tests were broken already on master, too :-/

pull bot pushed a commit to avitex/nixpkgs that referenced this pull request Jun 9, 2019
@vcunat
Merge NixOS#62873: bind: fix build on some ARMs
a1bb64e
@vcunat vcunat merged commit b473f17 into NixOS:master Jun 9, 2019
@lopsided98 lopsided98 deleted the bind-armv6l branch June 9, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @vcunat