boehm-gc: remove libatomic_ops, guile: 2.2.3 -> 2.2.4 #62850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
reviewed
Jun 8, 2019
lopsided98
force-pushed
the
boehm-gc-remove-libatomic-ops
branch
from
cce7f83
to
3a7b262
Compare
lopsided98
force-pushed
the
boehm-gc-remove-libatomic-ops
branch
from
3a7b262
to
08fed3b
Compare
matthewbauer
reviewed
Jun 8, 2019
| @@ -14,9 +14,6 @@ stdenv.mkDerivation rec { | |||
| sha256 = "1798rp3mcfkgs38ynkbg2p47bq59pisrc6mn0l20pb5iczf0ssj3"; | |||
| }; | |||
|
|
|||
| buildInputs = [ libatomic_ops ]; | |||
There was a problem hiding this comment.
Could you verify this works on 32-bit arm? I recall having to add it for static nix compilation, but maybe that was just because boost thought it needed it:
There was a problem hiding this comment.
I was able to compile boehm-gc and nix for armv7l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Follow up of #54402 for staging. This completely removes the
libatomic_opsdependency ofboehm-gcand removes the no longer neededdontStripattribute.libatomic_opsis not known to be needed on any platform supported by Nix, and if any platform did need it, it would still not work correctly because boehm-gc requires that all dependents link tolibatomic_opsas well, ifboehm-gcis linked withlibatomic_ops. This is not currently done, so any package that usesboehm-gcwould currently fail to compile on such a hypothetical platform. See #54402 for more details.I also updated guile to 2.2.4.
cc @dtzWill because you reviewed #54402
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)