Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.reflex: dontCheck #62876

Merged
merged 1 commit into from Jun 14, 2019
Merged

haskellPackages.reflex: dontCheck #62876

merged 1 commit into from Jun 14, 2019

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Jun 9, 2019

Motivation for this change

Reflex uses hlint in its test suite, failing the build if there are
any lint warnings. hlint depends on a newer haskell-src-exts than the
rest of the nixpkgs haskell infrastructure, so this avoids reflex
dependening on multiple versions of haskell-src-exts, which would
otherwise abort the build.

Tested with

nix-build -E '(import ./. {config.allowBroken = true;}).haskellPackages.reflex'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame
haskellPackages.reflex: dontCheck
5e41156 
Reflex uses hlint in its test suite, failing the build if there are
any lint warnings. hlint depends on a newer haskell-src-exts than the
rest of the nixpkgs haskell infrastructure, so this avoids reflex
dependening on multiple versions of haskell-src-exts, which would
otherwise abort the build.
@endgame endgame requested a review from basvandijk as a code owner June 9, 2019 02:20
@matthewbauer
Copy link
Member

How hard would it be to either bump haskell-src-exts or downgrade hlint? This is probably okay as a temporary workaround, but it sounds like anything using hlint will hit the samei ssue.

@endgame
Copy link
Contributor Author

endgame commented Jun 9, 2019

I honestly don't know. I'm not that clear on the haskell infra, or why any given version of a package is the nixpkgs default.

haskell-src-exts is overridden in three packages: hlint, hoogle, and lambdabot-plugins. So you'd have to depend on one of those and use haskell-src-exts some other way as well, which seems rare.

@matthewbauer matthewbauer requested a review from peti June 12, 2019 23:44
@peti peti merged commit 6917433 into NixOS:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@endgame @matthewbauer @peti