Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: 2.7.6 -> 2.8.0 #61664

Merged
merged 4 commits into from Jun 9, 2019
Merged

ansible: 2.7.6 -> 2.8.0 #61664

merged 4 commits into from Jun 9, 2019

Conversation

gabibbo97
Copy link
Contributor

@gabibbo97 gabibbo97 commented May 18, 2019

Motivation for this change

Update ansible

Things done

Updated Ansible to 2.8.0

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gabibbo97 gabibbo97 requested a review from FRidh as a code owner May 18, 2019 09:00
@FRidh
Copy link
Member

FRidh commented May 18, 2019

commit msg version is incorrect. Does it build with the current versions of botocore and such?

@costrouc
Copy link
Member

costrouc commented May 18, 2019

Also this file will need to be updated as well to reflect the new version. https://github.com/nixos/nixpkgs/blob/master/pkgs/tools/admin/ansible/default.nix

@gabibbo97
Copy link
Contributor Author

Hello, I have updated the pkgs/tools/admin/ansible/default.nix file

@marsam
Copy link
Contributor

marsam commented Jun 9, 2019

I took the liberty to bump it to 2.8.1, I hope you don't mind
@GrahamcOfBorg build ansible_2_6 ansible_2_7 ansible

@marsam marsam merged commit e49c77f into NixOS:master Jun 9, 2019
@marsam
Copy link
Contributor

marsam commented Jun 9, 2019

Tested locally on darwin and NixOS
Thanks @gabibbo97! btw feel free to ping me if any PR gets stuck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants