Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirrors: rename sourceforgejp to osdn #62878

Merged
merged 7 commits into from Jun 10, 2019
Merged

mirrors: rename sourceforgejp to osdn #62878

merged 7 commits into from Jun 10, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 9, 2019

Motivation for this change

SourceForge.jp renamed to OSDN on May 11, 2015. https://osdn.net/projects/sourceforge/news/24923

From Wikipedia:

On May 11, 2015, the site was renamed from "SourceForge.JP" to "OSDN".[10][11] In the same month that OSDN changed the site name, SourceForge caused two controversies: DevShare adware and project hijacking. In contrast, OSDN totally refuses adware bundling and project hijacking.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matthewbauer
matthewbauer reviewed Jun 9, 2019
View reviewed changes
pkgs/data/fonts/kochi-substitute-naga10/default.nix Outdated
@@ -5,7 +5,7 @@ in
fetchzip {
name = "kochi-substitute-naga10-${version}";

url = "mirror://sourceforgejp/efont/5411/kochi-substitute-${version}.tar.bz2";
url = "mirror://osdn/efont/efont/5411/kochi-substitute-${version}.tar.bz2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only have one efont/ right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed. Thanks!

@marsam marsam force-pushed the mirrors-rename-sourceforgejp-to-osdn branch from d5b9f1c to 699d751 Compare June 10, 2019 04:51
c0bw3b
c0bw3b approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 62878 1

1 package were build:
  • nkf

@matthewbauer matthewbauer merged commit b6db1b9 into NixOS:master Jun 10, 2019
@marsam marsam deleted the mirrors-rename-sourceforgejp-to-osdn branch June 10, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @matthewbauer @c0bw3b