Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Processing for ConvolverNode #17233

Merged
merged 1 commit into from Jun 12, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 7, 2019

The ConvolverNode should output a single channel of silence when it is not
actively processing. Active processing is already supported and just needed
to have the convolver output a single channel of silence when it is
constructed, before anything is connected to it.

Bug: 971389
Change-Id: Icc894cd7ea6dec60a1eccb0fa4a3aea68ac5b51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644899
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668149}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

The ConvolverNode should output a single channel of silence when it is not
actively processing.  Active processing is already supported and just needed
to have the convolver output a single channel of silence when it is
constructed, before anything is connected to it.

Bug: 971389
Change-Id: Icc894cd7ea6dec60a1eccb0fa4a3aea68ac5b51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644899
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668149}
@foolip foolip force-pushed the chromium-export-cl-1644899 branch from 9916fa7 to 4247c13 Compare June 12, 2019 10:24
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6531eab into master Jun 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1644899 branch June 12, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants