Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update nixpkgs-mozilla rev #62862

Merged
merged 1 commit into from Jun 9, 2019
Merged

doc: update nixpkgs-mozilla rev #62862

merged 1 commit into from Jun 9, 2019

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jun 8, 2019 •
edited

Motivation for this change

The previous one didn't work, returning a TOML parse error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asymmetric
doc: update nixpkgs-mozilla rev
4356b98 
The previous one didn't work, returning a TOML parse error.
vcunat
vcunat approved these changes Jun 9, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified before and after.

pull bot pushed a commit to milibopp/nixpkgs that referenced this pull request Jun 9, 2019
@vcunat
Merge NixOS#62862: doc: update nixpkgs-mozilla rev
17c0a1f
vcunat added a commit that referenced this pull request Jun 9, 2019
@vcunat
Merge #62862: doc: update nixpkgs-mozilla rev
30df265 
(cherry picked from commit 17c0a1f)
The problem happens on 19.03 as well.  This way we'll also update the
manual served on the web site.
@vcunat vcunat merged commit 4356b98 into NixOS:master Jun 9, 2019
@asymmetric asymmetric deleted the doc/nightly branch June 9, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asymmetric @vcunat