Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] backport wasmtime #62858

Merged
merged 1 commit into from
Jun 9, 2019
Merged

[19.03] backport wasmtime #62858

merged 1 commit into from
Jun 9, 2019
+1,515 −0

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jun 8, 2019 •
edited
Loading

Motivation for this change

This is a backport of 2 of @matthewbauer's wasm commits, stripped to the bare minimum so that they only just init the package.

I added myself as a "co-author" as I modified the commit slightly (removed the changes to lib/systems/default.nix for example), but credit is all his.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 8, 2019
@ofborg ofborg bot requested a review from matthewbauer June 8, 2019 13:13
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 8, 2019
@matthewbauer
Copy link
Member

@GrahamcOfBorg build wasmtime

@matthewbauer
Copy link
Member

Can you make it x86_64-linux only for now?

@matthewbauer @asymmetric
wasmtime: init
f494971 
Co-authored-by: Lorenzo Manacorda <lorenzo@mailbox.org>
@vcunat vcunat merged commit f494971 into NixOS:release-19.03 Jun 9, 2019
vcunat added a commit that referenced this pull request Jun 9, 2019
@vcunat
Merge #62858: backport wasmtime into release-19.03
fa986a8
@asymmetric asymmetric deleted the wasmtime branch June 9, 2019 08:17
@asymmetric
Copy link
Contributor Author

@matthewbauer how did you produce the Cargo.lock patch?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Jun 9, 2019
@matthewbauer
Copy link
Member

I think it just came from a successful cargo build run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asymmetric @matthewbauer @vcunat