Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] matrix-synapse: 1.1.0 -> 1.2.1 #65463

Merged
merged 1 commit into from Jul 27, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jul 27, 2019

Motivation for this change

Security update: see https://github.com/matrix-org/synapse/releases/tag/v1.2.1

Package builds, unit tests and NixOS test are passing.

Supersedes #65413

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC package maintainers: @Ralith @roblabla @Ekleog

@pacien pacien mentioned this pull request Jul 27, 2019
10 tasks
@pacien pacien changed the title matrix-synapse: 1.1.0 -> 1.2.1 [security] matrix-synapse: 1.1.0 -> 1.2.1 Jul 27, 2019
@ofborg ofborg bot requested a review from Ekleog July 27, 2019 11:09
@pacien
Copy link
Contributor Author

pacien commented Jul 27, 2019

Backporting this security update to release-19.03 would require a more recent version of pythonPackages.service-identity (18.1.0 instead of 17.0.0 currently in 19.03).

I'm not sure whether we should update that package globally or use a different version locally for the backport.

Backport: #65464

@Ekleog
Copy link
Member

Ekleog commented Jul 27, 2019

@ofborg build nixosTests.matrix-synapse

@pacien
Copy link
Contributor Author

pacien commented Jul 27, 2019

@Ekleog The NixOS test seems to be broken on master when running on ofborg (matrix-synapse seems to complain about not being able to connect to postgres).
It passes locally on NixOS 19.03 though.

@Ekleog
Copy link
Member

Ekleog commented Jul 27, 2019

@pacien yup, already had that issue last time, with the verdict being that it's likely an issue of ofborg being too slow -- currently running locally, will merge as soon as it completes :)

@pacien
Copy link
Contributor Author

pacien commented Jul 27, 2019

It seems to work fine on the release-19.03 branch but fails consistently on master so it might not be a slowness issue.

@Ekleog Ekleog merged commit dd47b2d into NixOS:master Jul 27, 2019
@Ekleog
Copy link
Member

Ekleog commented Jul 27, 2019

I would guess it's an upgrade to postgresql that's slowed down startup, and so when running in a VM in a VM (@grahamc's guess last time I asked was it was due to an ofborg runner running inside a VM) it goes over the startup timeout.

Anyway, there is no regression compared to current master, and this looks like a postgresql issue, so I'm going to merge this for now and poke @ocharles @thoughtpolice @danbst in case they have some idea of why this might be happening with postgresql on ofborg and/or whether they saw similar things happening with the postgresql tests. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants