Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
base: 8efdb8afa726
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
compare: dfa6383943e1
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Jul 27, 2019

  1. access.direct.demultiplexer: introduce software side queue length limits 

    This implements a configurable thireshold for FIFO data queueing on the
Python side, with pushback. Previously, any data was buffered eagerly,
e.g. an applet sending data on the hardware side and never receiving
it on the software side (or vice versa) would cause the data to pile up
in Python buffers at full speed, with no memory usage limit.

With this patch, the user may specify queue size limits. These limits
are not strict, but rather just thresholds for pushback. If the user
configures a 1MB FIFO limit and writes 100MB, the write will complete
immediately, but a subsequent write will block until 99MB of data has
been successufully queued with the USB subsystem (URB buffers do not
count towards the limit). Similarly, configuring a 1MB read limit
will allow a URB completion that crosses that threshold to complete,
but no further URBs will be re-queued until the application reads data
from the FIFO, eventually causing the on-device FIFO to fill up and
stop accepting writes from the gateware.
    @marcan @whitequark
    marcan authored and whitequark committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    b855a71 View commit details
    Browse the repository at this point in the history

  2. support.endpoint: introduce queue_size argument 

    This limits the receive queue size and pushes back on the underlying
transport when the receive queue is full.
    @marcan @whitequark
    marcan authored and whitequark committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    a321cb3 View commit details
    Browse the repository at this point in the history

  3. applet.video.ws2812_output: implement pushback

    @marcan @whitequark
    marcan authored and whitequark committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    dfa6383 View commit details
    Browse the repository at this point in the history