syncthingtray: init at 0.9.1 #65480
syncthingtray: init at 0.9.1 #65480
Conversation
|
Thank you for packaging this. I'll likely make use of it at some point. I've left a few comments I hope you find constructive and useful. |
|
Where are the comments @aanderse ? |
Apparently stuck in the 'Pending' state! Sorry 😆 |
doronbehar
force-pushed
the
package-syncthingtray
branch
3 times, most recently
from
5e67084
to
e90ec05
Compare
doronbehar
force-pushed
the
package-syncthingtray
branch
from
0b3e33f
to
78228e9
Compare
|
Since this is also labeled with darwin you might be interested in the following issue covering some special tweaks required for MacOS: Martchus/syncthingtray#37 So for MacOS changes are required which have not been released yet. By the way, I'm going to release the next version (0.10.0) soon. |
Use only boolean flags to control if these will be included
|
@Martchus I haven't read thoroughly the whole discussion you've had there at Martchus/syncthingtray#37 but we've had an issue with Darwin when packaging As |
|
@doronbehar Things - including cpp-utilities - are actually supposed to build for MacOS. For cpp-utilities you need
Me neither. So my level of support for this is also quite low. |
|
Oh right then, @timokau |
|
Thank you for the contribution and your patience :) Feel free to ping me if you want me to review one of your PRs in the future. |
|
Thanks :) it was a pleasure. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)