Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multimc: wrapQtAppsHook, add xrandr for lwjgl 2.9.2 #65486

Merged
merged 1 commit into from Jul 28, 2019
Merged

multimc: wrapQtAppsHook, add xrandr for lwjgl 2.9.2 #65486

merged 1 commit into from Jul 28, 2019

Conversation

samlich
Copy link
Contributor

@samlich samlich commented Jul 27, 2019

Motivation for this change

#65399 fixed by stdenv.mkDerivation => mkDerivation as new docs require
LWJGL/lwjgl#128 fixed by adding xrandr to PATH

cc @cleverca22

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    545 MB before
    545 MB with xrandr
    722 MB with wrapQtAppsHook
    722 MB with both
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cleverca22 July 27, 2019 23:11
@ghost
Copy link

ghost commented Jul 28, 2019

Builds and works fine, tested launching a vanilla 1.14 instance.
For some reason the bin folder contains some shared object files and jar files that are only used internally. Those should be moved to the appropriate directories if possible, but I can address that in a seperate PR.

@samueldr samueldr mentioned this pull request Jul 28, 2019
Merged
@samueldr
Copy link
Member

Hi! 👋

Thanks for your first contribution!

Overall, a good contribution 👍, the only thing that I would have liked seen done differently (but still acceptable this way) is to have two commits, one for the fix for wrapping, and one for the xrandr fix. Only something to keep in for your next contributions :).

@petabyteboy you're right that those files should be somewhere else. Though yeah, that's not this PR's business. Though it does add one small hack to make the wrap hook pass.

@samueldr samueldr merged commit ed51432 into NixOS:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samlich @samueldr @Janik-Haag