stdenv: correct cross CMAKE_SYSTEM_NAME #65484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As described in cmake cross instructions,
CMAKE_SYSTEM_NAME
should be set to "Generic" if there is no applicable OS. Otherwise it gets set to the build host's system name which can result in impure and unpredictable output.I noticed this was unset while messing around with #65483 and cross-compiling compiler-rt, though it only affects bare-metal cross compiling and isn't really related or necessary to get compiler-rt working so split off into its own PR.
(I hope this usage of lib is okay? I couldn't figure out a nice way to do null coalescing...)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)