Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passff-host: fix native messaging manifest path #65488

Merged
merged 1 commit into from Aug 1, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jul 28, 2019

Motivation for this change

Match other native messaging applications and the firefox wrapper's expectation that manifests exist in /lib/mozilla/native-messaging-hosts

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do believe it's better to install these manually, but can you make symlinks for
the other paths as well?

pkgs/tools/security/passff-host/default.nix Outdated Show resolved Hide resolved
Match other native messaging applications
and the firefox wrapper's expectations.
@arcnmx arcnmx force-pushed the pr-passff-manifest branch 3 times, most recently from c5c9c9d to c73ff37 Compare July 31, 2019 16:08
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@worldofpeace worldofpeace merged commit ba4e5a3 into NixOS:master Aug 1, 2019
@arcnmx arcnmx deleted the pr-passff-manifest branch November 26, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants