Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluxctl: init at 1.13.1 #65433

Merged
merged 1 commit into from Jul 27, 2019
Merged

fluxctl: init at 1.13.1 #65433

merged 1 commit into from Jul 27, 2019

Conversation

Gonzih
Copy link
Contributor

@Gonzih Gonzih commented Jul 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit July 26, 2019 19:46
@yurrriq
Copy link
Member

yurrriq commented Jul 27, 2019

Should we just call this fluxctl? I think the reason kubernetes-helm is called that is that there exists another package called helm.

@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 27, 2019

renamed, rebased & squashed

@Gonzih Gonzih changed the title kubernetes-fluxctl: Init at 1.13.1 fluxctl: Init at 1.13.1 Jul 27, 2019
yurrriq
yurrriq approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalbasit kalbasit changed the title fluxctl: Init at 1.13.1 fluxctl: init at 1.13.1 Jul 27, 2019
@kalbasit
Copy link
Member

@GrahamcOfBorg build fluxctl

@kalbasit kalbasit merged commit a0c413f into NixOS:master Jul 27, 2019
@Gonzih Gonzih deleted the gonzih/fluxctl branch July 27, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@yurrriq yurrriq yurrriq approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gonzih @yurrriq @kalbasit