Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #65430 from pasqui23/zbd #65430

Merged
merged 1 commit into from Jan 21, 2020
Merged

Merge pull request #65430 from pasqui23/zbd #65430

merged 1 commit into from Jan 21, 2020

Conversation

pasqui23
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

infinisil
infinisil requested changes Jan 16, 2020
View reviewed changes
pkgs/shells/zsh/zsh-bd/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/zsh-bd/default.nix Outdated Show resolved Hide resolved
@infinisil
Copy link
Member

Looking good, all that's left to do now is to clean up the history: It should only be a single commit with the message "zsh-bd: init at 2018-07-04"

@infinisil infinisil changed the title zsh-bd:init at 2018-07-04 Merge pull request #65430 from pasqui23/zbd Jan 21, 2020
@infinisil infinisil merged commit b785f2a into NixOS:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pasqui23 @infinisil