Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k9s: Init at 0.7.13 #65432

Merged
merged 1 commit into from Jul 27, 2019
Merged

k9s: Init at 0.7.13 #65432

merged 1 commit into from Jul 27, 2019

Conversation

Gonzih
Copy link
Contributor

@Gonzih Gonzih commented Jul 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

yurrriq
yurrriq requested changes Jul 26, 2019
View reviewed changes
Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please fix the first line.

pkgs/applications/networking/cluster/k9s/default.nix Outdated Show resolved Hide resolved
@yurrriq
Copy link
Member

yurrriq commented Jul 26, 2019

@GrahamcOfBorg build kubernetes-k9s

@yurrriq
Copy link
Member

yurrriq commented Jul 26, 2019

@GrahamcOfBorg build kubernetes-k9s

@ofborg ofborg bot requested a review from kalbasit July 26, 2019 19:45
@ofborg ofborg bot requested a review from kalbasit July 27, 2019 01:00
yurrriq
yurrriq requested changes Jul 27, 2019
View reviewed changes
Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just call it k9s since there's no conflict?

pkgs/applications/networking/cluster/k9s/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 27, 2019

rebased & squashed, applied all suggestions

@Gonzih Gonzih changed the title kubernetes-k9s: Init at 0.7.13 k9s: Init at 0.7.13 Jul 27, 2019
yurrriq
yurrriq approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jirkadanek
jirkadanek approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@jirkadanek jirkadanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARCHITECTURE = [ "NixOs x86_64" ]

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on ARCHITECTURE
  • executables tested on ARCHITECTURE
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Comments

Did not know about the tool before. Looks pretty good!

pkgs/applications/networking/cluster/k9s/default.nix Outdated Show resolved Hide resolved
@kalbasit
Copy link
Member

@GrahamcOfBorg build k9s

@kalbasit kalbasit merged commit b5590ff into NixOS:master Jul 27, 2019
@Gonzih Gonzih deleted the gonzih/k9s branch July 27, 2019 17:49
@Gonzih
Copy link
Contributor Author

Gonzih commented Jul 27, 2019

Thank you everyone for taking look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@yurrriq yurrriq yurrriq approved these changes

@jirkadanek jirkadanek jirkadanek approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gonzih @yurrriq @kalbasit @jirkadanek