Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh-powerlevel10k:init at 2019-07-23 #65431

Closed
wants to merge 2 commits into from
Closed

zsh-powerlevel10k:init at 2019-07-23 #65431

wants to merge 2 commits into from

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Jul 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@averelld
Copy link
Contributor

What about #65246? Maybe we only need to bump the version there.

@pasqui23
Copy link
Contributor Author

@averelld you're right

@pasqui23 pasqui23 closed this Jul 27, 2019
@zyradyl zyradyl mentioned this pull request Jul 28, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pasqui23 @averelld