Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games/crawl: add support for MacOS/Darwin builds for Dungeon Crawl #65493

Merged
merged 1 commit into from Jul 28, 2019
Merged

games/crawl: add support for MacOS/Darwin builds for Dungeon Crawl #65493

merged 1 commit into from Jul 28, 2019

Conversation

virusdave
Copy link
Contributor

@virusdave virusdave commented Jul 28, 2019 •
edited

games/crawl: Add support for darwin builds. Also,
compression/advancecomp: Add support for darwin builds in meta (which already worked).

advancecomp already compiles out-of-box on darwin.
crawl mostly did, but required that the osx frameworks be made available and
disable the makefile's attempt to force-build the contrib libraries.

I've tested non-tiles build on mac, and it seems fine.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@virusdave
games/crawl: add support for MacOS/Darwin builds
b3b4184 
games/crawl: Add support for darwin builds.  Also,
compression/advancecomp: Add support for darwin builds in meta (which already worked).
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Jul 28, 2019
@ofborg ofborg bot requested review from abbradar and 7c6f434c July 28, 2019 06:45
@7c6f434c 7c6f434c merged commit bca933e into NixOS:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@virusdave @7c6f434c