Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo: remove darwin hack #65495

Closed
wants to merge 1 commit into from
Closed

cargo: remove darwin hack #65495

wants to merge 1 commit into from

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jul 28, 2019

Motivation for this change

This seems to have recently resolved itself with updates and is mysteriously no longer necessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcnmx arcnmx requested review from LnL7 and Mic92 as code owners July 28, 2019 07:40
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: rust labels Jul 28, 2019
@ofborg ofborg bot requested a review from wizeman July 28, 2019 07:54
@LnL7
Copy link
Member

LnL7 commented Jul 28, 2019

Yeah, #63381 resolved most if not all remaining CF weirdness. Could you also remove CoreFoundation from buildInputs?

@arcnmx
Copy link
Member Author

arcnmx commented Jul 28, 2019 •
edited

Like that? (wanted to remove from rls too which depends on cargo but keeping that in #63759)

@arcnmx
cargo: remove darwin hack
5abd384 
This seems to have recently resolved itself with updates
and is no longer necessary.
@arcnmx
Copy link
Member Author

arcnmx commented Jul 28, 2019

Nope that does not work, CoreFoundation and the symbol is still needed, it's just that #63381 removed the need for the manual cflags (due to pulling in the setuphook that previously was cf-private).

@Mic92
Copy link
Member

Mic92 commented Jul 29, 2019

@GrahamcOfBorg build cargo

@Mic92
Copy link
Member

Mic92 commented Jul 29, 2019

Pushed to staging: 507dfa0...b53e237

@Mic92 Mic92 closed this Jul 29, 2019
@arcnmx arcnmx deleted the rust-darwin-cargo-unhack branch July 29, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@wizeman wizeman Awaiting requested review from wizeman

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcnmx @LnL7 @Mic92