ceph: 12.2.7 -> 14.2.1 #65470
ceph: 12.2.7 -> 14.2.1 #65470
Conversation
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
Good work! (And to all of the people involved earlier as well!) Refresh my memory though; if we decided not to ship the dashboard for now, do we even need the cerrypy hackery? |
|
Since 14.2.0, they've broken out the dashboard to its own package. So we shouldn't need to have to have anything to do with it in the ceph build henceforth. (reference: "Also, the Ceph Dashboard is now split into its own package named I'm actually going to prime and install a new ceph node this weekend, I'll do it with this PR to give it some more testing. |
|
<itshappening.gif> |
|
|
Update: We've just deployed this branch to our production env. at my day job, today. So far no issues. Ok. Even though we can't get rid of cherrypy, we can still decide to merge this for 19.09? What do you say @lejonet @srhb? :-) I removed the "WIP" in the title here. What else is required before we can merge this? |
|
The two of you use it actively and I'll be okay with your decision. However, it looks like the dashboard is now enabled by default -- is that safe? I don't recall whether the interface is protected initially or whether it even matters. Other than that: Are any release notes required? |
Ah.. You mean, in the test? (https://github.com/NixOS/nixpkgs/pull/65470/files#diff-07c1a40dbc7cbf287840ba0dbbf4cd10R44) and then the dashboard just stays disabled, with the cluster still being healthy. What I don't know though; is why the dashboard code is even still in tree and still exist in the mgr-module namespace? I've read the same release note as @lejonet, hence I would have expected something like: Anyway. We can of course remove the attempted dashboard enabling from the test, and we should be able to remove the cherrypy patches on Also; The NixOS test fails for other reasons. Pretty embarrassing. I'll have a look at that as well. :) |
|
I never managed to deploy a ceph node with this PR because systemd-242 (the version "locked" in, in the PR branch) not liking my epyc SoC. I'm also a bit confused why the dashboard is still in the codebase and all. The dashboard present in the 11-12 releases was completely without auth and such but iirc the biggest change outside of breaking it out to its own package in 14.2.x is that they've fitted a much more comprehensive dashboard, with auth, acls and other bells and whistles. Thus I would defer the decision to @johanot, because he have the version actually running. Tho it would be prudent to note the cherrypy problem as a heads up to those that actually use modules. Edit: |
johanot
force-pushed
the
ceph-14-upstream
branch
from
80ee631
to
06eea9b
Compare
|
Added 3 new commits, including test fixes and rel note text. also, rebased with master. But after the rebase, ceph doesn't build anymore; because: #67676 . Don't have time to try and upgrade kinetic-cpp-client today. |
|
Merged the kinetic-cpp-client openssl pinning to not block this. |
johanot
force-pushed
the
ceph-14-upstream
branch
from
06eea9b
to
3920bf3
Compare
|
Almost certain this will timeout. But let's try. |
|
I'm inclined to drop kinetic support due to the potential headache of mixed openssl versions. |
|
Looks like there's some bootstrap permission errors in the test as well. |
johanot
force-pushed
the
ceph-14-upstream
branch
from
3920bf3
to
d9ff6bd
Compare
|
Ok @srhb. Rebased with master again, conflicts fixed. Squashed from 20 down to 11 commits. Have a look at the latest 3 commits on the branch, those are the fixes for the newest issues. I believe the decision to remove kinetic is correct, since the project seems to be abandoned by Seagate anyway. I wrote on the ceph mailing list yesterday trying to get a current status of kinetic support in ceph - still waiting for a response on that one. Still Ceph doesn't build, because of cherrypy now. Feel free to cherrypick (no pun intended) this: #68001 for testing. |
|
Maybe we should just throw pyjwt at the dashboard anyway, and see what sticks. |
globin
force-pushed
the
ceph-14-upstream
branch
from
d9ff6bd
to
02e7e74
Compare
|
Rebased again, as a fix for cherrypy was pushed to master, tests succeed locally. |
|
Dashboard working now, will squash, rearrange and merge tonight, hopefully. :) |
* maintain only one version * ceph-client: init * include ceph-volume python tool in output nixos/ceph: extraConfig, fix test, wait for ceph-mgr to become active * run ceph with disk group permission * add extraConfig option for the global section needed per cluster * clear up how ceph.conf is generated * fix ceph testcase
* remove kinetic * release note * add johanot as maintainer nixos/ceph: create option for mgr_module_path - since the upstream default is no longer correct in v14 * fix module, default location for libexec has changed * ceph: fix test
srhb
force-pushed
the
ceph-14-upstream
branch
from
31e1338
to
fb22d67
Compare
|
Thanks everyone involved for the hard work! |
|
@srhb this broke the manual in master |
|
My bad. I'll fix it right away. |
|
Has anyone looked at updating this to 14.2.3? Both .2 and .3 had critical fixes that we needed at $WORK (Not running NixOS) |
|
@lordcirth it is done :) #68138 |
|
@johanot Thanks! I guess I forgot to search for closed issues. |
Motivation for this change
Make ceph up-to-date and not broken.
This PR probably has a better chance of being merged before 19.09 than #49866.
It includes all commits from #49866 , plus:
b54b5f9
Result:
It has been rebased with master, and It builds! 馃帀
Dashboard:
Not included yet. Working on it. That's the WIP part. If we decide not to include that, we can probably skip all the cherrypy patches.
Testing:
Real-life testing has been performed with 14.2.1 already.
The use of in-tree rocksdb however has not.
Will deploy this addition to my own ceph environment soon.
A bunch of squashing is probably also needed before merging.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)