Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitaly: fix hashes #65468

Merged
merged 1 commit into from Jul 29, 2019
Merged

gitaly: fix hashes #65468

merged 1 commit into from Jul 29, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 27, 2019

It seems the sha256 hashes of 3 gitaly dependencies were wrong or
changed.

See: #64550 (comment)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jslight90 for testing.

@flokli
gitaly: fix hashes
89aae90 
It seems the sha256 hashes of 3 gitaly dependencies were wrong or
changed.
@flokli flokli requested review from fpletz and globin July 27, 2019 12:34
@flokli flokli mentioned this pull request Jul 27, 2019
Merged
10 tasks
@globin globin merged commit ab82403 into NixOS:master Jul 29, 2019
@globin
Copy link
Member

globin commented Jul 29, 2019

vgo2nix seems to mess up for some repositories, it seems like nix-prefetch-git is returning the wrong hash already. (which added it to my store so I didn't notice)

cc @adisbladis

@adisbladis
Copy link
Member

adisbladis commented Jul 29, 2019 •
edited

I'd be interested to know how to reproduce or even what's in the store paths with the faulty hashes.
I have noticed cases where nix-prefetch-git will return an empty path and vgo2nix takes that into account but I don't know what I can reasonably do except reimplement nix-prefetch-git.

@globin
Copy link
Member

globin commented Jul 29, 2019

Running pkgs/applications/version-management/gitlab/update.py should reproduce this, it runs vgo2nix in the gitaly source dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @globin @adisbladis