Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openscad: Use qt5's own mkDerivation #65522

Merged
merged 1 commit into from Jul 28, 2019
Merged

openscad: Use qt5's own mkDerivation #65522

merged 1 commit into from Jul 28, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 28, 2019 •
edited

Motivation for this change

Fixes #65514, related to #65399.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut marked this pull request as ready for review July 28, 2019 20:10
bjornfor
bjornfor requested changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put "Fixes #65514, related to #65399." also into the commit message (since that's what goes into the project history).

@mmahut
Copy link
Member Author

mmahut commented Jul 28, 2019

@bjornfor thank you, done.

@ofborg ofborg bot requested a review from bjornfor July 28, 2019 21:07
@worldofpeace worldofpeace merged commit 239fffc into NixOS:master Jul 28, 2019
@worldofpeace
Copy link
Contributor

Oops, noticed that this was using qt5 and libsForQt5 directly. Can you fix this also?

(similar to the situation with not using pythonPackages in python-modules`)

@mmahut mmahut mentioned this pull request Jul 28, 2019
Merged
10 tasks
mmahut added a commit to mmahut/nixpkgs that referenced this pull request Jul 29, 2019
@mmahut
openscad: not using qt5 and libsForQt5 directly
71a76ff 
Additional fix to NixOS#65522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@gebner gebner Awaiting requested review from gebner

@the-kenny the-kenny Awaiting requested review from the-kenny

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openscad: fails to start
3 participants
@mmahut @worldofpeace @bjornfor